We’ve been talking about key/value pairs. The log/slog package has a name for these: Attr (short for “attribute”). And there’s more than one way to build an attribute:
Attrs and Values
An Attr is a key-value pair. The Logger output methods accept Attrs as well as alternating keys and values. The statement
slog.Info("hello", slog.Int("count", 3))behaves the same as
slog.Info("hello", "count", 3)There are convenience constructors for Attr such as Int, String, and Bool for common types, as well as the function Any for constructing Attrs of any type.
You might wonder why there are two ways to do this. I know I do!
I can guess, though: Allowing both convenience, and precision.
Passing raw key/value pairs is generally more convenient:
slog.Info("request served", "url", req.URL.String(), "method", req.Method, ...)
But it’s also error-prone. Particularly with long lists of attributes, it’s easy to miss either a key or a value, which can trigger all sorts of strange behavior!
There may also be times when you want to pass around attributes, and that’s often easier as discrete slog.Attr values than as a slice of key/value pairs.
And finally, there may be a marginal performance gain by using one of the type-specific attribute constructors, since it avoids a type assertion at runtime—not a concern most of us will ever need to worry about, of course.
So should you prever key/value pairs ("key", value), or the explicit attribute constructors (slog.Int("key", value)). Your call. I generally prefer the explicit constructors, because it’s more explicit, and less error prone—particularly if the log ever grows more key/value pairs over time. But: I would never hold up a code review because somebody else chose the other format instead!